-
Notifications
You must be signed in to change notification settings - Fork 0
Config service fixes & improvements #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
adams85
wants to merge
10
commits into
master
Choose a base branch
from
configservice-improvements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3bc4d5a
to
ca37ce0
Compare
…for improved precision and resistance to system/user clock adjustments
…e tolerance of time-sensitive tests
ca37ce0
to
220d8ca
Compare
220d8ca
to
c30d22a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the purpose of your pull request
This PR makes some corrections and improvements around config services:
performance.now
) instead of system clock (new Date()
) for scheduling poll iterations in Auto Polling mode for improved precision and resistance to system clock adjustments (time sync, user initiated clock adjustments, etc.)forceRefreshAsync
to report failure and log a warning in offline mode only when the client is not configured to use an external cache. (Low impact behavioral BC.)clientReady
event consistent with other SDKs in Auto Polling mode. When the client is offline,clientReady
is emitted as soon as the initial sync with the external cache completes. (Low impact behavioral BC.)clientReady
event and thewaitForReady
method as the previous description was misleading.configChanged
event when the local cache is updated as a result of synchronization with the external cache. (Low impact behavioral BC.)configChanged
once per config refresh operation, eliminate race conditions around cache write, and improve performance in high concurrency situations by deduplicating config refresh instead of config fetch operation only.configFetched
event, which can be used to detect network issues in Auto Polling mode.Related issues (only if applicable)
https://trello.com/c/XZdBOLY1
https://trello.com/c/mU63054x
How to test? (only if applicable)
n/a
Security (only if applicable)
n/a
Requirement checklist (only if applicable)